Skip to content

gh-58247: clarify metavar behaviour in ArgumentParser.add_subparsers - #148671

Merged
savannahostrowski merged 4 commits into
python:mainfrom
SofieTorch:gh-58247-fix-subparsers-metavar-docs
Oct 21, 2026
Merged

gh-58247: clarify metavar behaviour in ArgumentParser.add_subparsers#148671
savannahostrowski merged 4 commits into
python:mainfrom
SofieTorch:gh-58247-fix-subparsers-metavar-docs

Conversation

@SofieTorch

@SofieTorch SofieTorch commented Apr 17, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Documents how metavar arg affects the --help output in subparsers.

Related to issue #58247

📚 Documentation preview 📚: https://cpython-previews--148671.org.readthedocs.build/

@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Apr 17, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Apr 17, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 17, 2026
Closed
savannahostrowski
savannahostrowski requested changes Apr 20, 2026
View reviewed changes

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sofie!

@bedevere-app

bedevere-app Bot commented Apr 20, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

savannahostrowski
savannahostrowski reviewed Apr 20, 2026
View reviewed changes
Comment thread Doc/library/argparse.rst Outdated
@savannahostrowski savannahostrowski moved this from Todo to In Progress in Docs PRs Apr 20, 2026
@savannahostrowski savannahostrowski linked an issue Jun 5, 2026 that may be closed by this pull request
Add "metavar" argument to add_subparsers() in argparse #58247
Closed
@savannahostrowski

savannahostrowski commented Jun 5, 2026

Copy link
Copy Markdown
Member

Hey @SofieTorch, still up for finishing this one? Happy to chat more too!

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 5, 2026
@savannahostrowski
savannahostrowski enabled auto-merge (squash) October 21, 2026 18:44
@read-the-docs-community

read-the-docs-community Bot commented Oct 21, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35306589 | 📁 Comparing 72eb527 against main (2a07ff9)

  🔍 Preview build  

463 files changed · + 19 added · ± 443 modified · - 1 deleted

+ Added

± Modified

- Deleted

@savannahostrowski
savannahostrowski merged commit 1bad1f2 into python:main Oct 21, 2026
34 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Docs PRs Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowski savannahostrowski savannahostrowski approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add "metavar" argument to add_subparsers() in argparse

2 participants

@SofieTorch @savannahostrowski